Fix the self-healing PR descriptions and avoids em dashes at creation - #3444
Merged
Conversation
Em dashes are not used in Strapi documentation and are a strong tell of unedited AI-generated prose. The self-healing workflow now lints them out before committing, and this check is the net under that: it reports, it never edits the PR.
The Style Checker prompt already forbids em dashes, but a prompt is a probabilistic filter and style-lint.sh is not: an em dash still reached PR #3443. Micro-edits skip the Style Checker entirely, so the script is their only style guard. The Router block is reordered first, since its git reset ran after the file edits and would have destroyed them.
The canned body named no change, put the source PR as a bare URL instead of a Documents link, carried no preview link, and repeated boilerplate the label, assignee and draft status already convey. Both prompts now build the description from the actual diff. Also repairs the broken line continuations in the Drafter gh pr create call, which would have dropped the body, labels and draft flag.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
internal
…ning a PR A remaining em dash costs a few seconds of editing at review time. An abandoned PR costs re-reading the strapi/strapi diff and writing the page by hand, and the source PR does not come back: the next run only lists PRs merged in the last 24 hours, so anything skipped is silently lost.
The Drafter prompt already forbade em dashes and PR #3443 carried one anyway: the rule sits 300 lines before the first sentence is written, so it now runs again as a sweep at output time. Micro-edits had no rule at all, since that path loads router.md only and router.md never mentioned em dashes.
pwizla
changed the title
pwizla
commented
Sep 4, 2026
pwizla
left a comment
pwizla
left a comment
Collaborator
Author
There was a problem hiding this comment.
LGTM, let's merge and test in prod 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the self-healing workflow so its PRs stop arriving in a state that needs hand-cleaning at review time, after #3443 came in with a canned description and an em dash.