Skip to content

fix: configure Nvidia reranker truncation - #2565

Open
erichare wants to merge 6 commits into
mainfrom
fix/nvidia-rerank-truncate-config
Open

fix: configure Nvidia reranker truncation#2565
erichare wants to merge 6 commits into
mainfrom
fix/nvidia-rerank-truncate-config

Conversation

@erichare

@erichare erichare commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

What this PR does:

  • Add a validated model-level reranker truncate setting.
  • Configure Nvidia with END and use it in provider requests.
  • Keep NONE explicit when the setting is unavailable.

Which issue(s) this PR fixes: Fixes #2568

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@erichare
erichare requested a review from a team as a code owner August 25, 2026 02:31
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 53.44%
This PR 53.55%
Delta 🟢 +0.11%
✅ Coverage improved!

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 53.55% 🍏
Files changed 79.17% 🍏

File Coverage
NvidiaRerankingProvider.java 98.81% 🍏
RerankingProvidersConfigImpl.java 78.57% 🍏
RerankingProvidersConfig.java 47.37% 🍏
RerankingProviderConfigProducer.java 32% -1.67%

@erichare
erichare requested a review from amorton August 25, 2026 03:14
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 71.45%
This PR 71.45%
Delta 🟢 +0.00%
✅ Coverage improved!

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 71.45% -0.01% 🍏
Files changed 62.5% 🍏

File Coverage
RerankingProvidersConfig.java 98.68% 🍏
RerankingProviderConfigProducer.java 32% -1.67%
RerankingProvidersConfigImpl.java 28.57% 🍏
NvidiaRerankingProvider.java 12.5% -2.38%

@github-actions

Copy link
Copy Markdown
Contributor

📉 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 72.76%
This PR 72.76%
Delta 🔴 -0.00%
⚠️ Coverage decreased

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 72.76% -0.01% 🍏
Files changed 62.5% 🍏

File Coverage
RerankingProvidersConfig.java 98.68% 🍏
RerankingProviderConfigProducer.java 32% -1.67%
RerankingProvidersConfigImpl.java 28.57% 🍏
NvidiaRerankingProvider.java 12.5% -2.38%

@amorton amorton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 , have not reviewed but we need PRs to follow the template pls

https://github.com/stargate/data-api/blob/main/.github/pull_request_template.md

@erichare erichare linked an issue Aug 25, 2026 that may be closed by this pull request
@erichare
erichare requested a review from amorton August 25, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too large of $lexical field causes RERANKING_PROVIDER_CLIENT_ERROR

2 participants