Conversation
LogEntryOutputProcessor only kept the first two parents (mergeA/mergeB) and dropped the parent edge for every single-parent commit, which breaks commit graph reconstruction (lost first-parent edges and octopus merge branches beyond the second parent). - GitLogEntry: add parents list carrying the full parent chain in git order; constructor backfills from mergeA/mergeB when parents is null for backwards compatibility; expose read-only Parents property. - LogEntryOutputProcessor: collect all parent hashes during parsing. - Tests: single-parent and 3-parent octopus merge parsing.
XChen446
marked this pull request as ready for review
August 24, 2026 09:36
XChen446
added a commit
to VRChatCN-Kipfel/git-for-unity
that referenced
this pull request
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
\LogEntryOutputProcessor\ only keeps the first two parents (\mergeA/\mergeB): the parent edge is lost entirely for every single-parent commit (the fields are only assigned when there are 2+ parents), and octopus merges beyond the second parent are dropped. This breaks commit-graph reconstruction from \GitLogEntry\ (missing first-parent edges, missing octopus branches).
Verified on a full 5394-commit log dump: 3535 single-parent commits all produced empty parent fields.
Changes
Impact
No breaking changes: binary-compatible field addition, optional constructor parameter, existing assertions (\AssertEqual) untouched.