internal: periodic collector DNS re-resolve (fork CI only) - #7
Open
songzhendong wants to merge 1 commit into
Open
songzhendong wants to merge 1 commit into
songzhendong wants to merge 1 commit into
Conversation
songzhendong
force-pushed
the
feat/periodic-dns-resolve
branch
4 times, most recently
from
September 13, 2026 14:20
1d9454e to
7e50e26
Compare
Add SW_AGENT_COLLECTOR_IS_RESOLVE_DNS_PERIODICALLY and SW_AGENT_COLLECTOR_GRPC_CHANNEL_CHECK_INTERVAL (Java collector.* parity). When enabled, hostnames expand to static ipv4:/ipv6: dial targets and are re-checked on the interval; any IP-set change (grow or shrink) rebuilds the pick_first channel (sync thread + aio watch task). Hardening: generation-scoped callbacks; DNS failure keeps previous dial plan; sync/aio bind is atomic (construct then commit; abandon uncommitted channel); sync rebuild restores the previous channel if subscribe fails after commit; sync closes old channel only after successful bind and outside the lock; aio begin_shutdown before task cancel; Event wake when old.close fails. Unit coverage in test_dns_reresolve.py (sync + aio).
songzhendong
force-pushed
the
feat/periodic-dns-resolve
branch
5 times, most recently
from
September 14, 2026 03:04
b0a48de to
06d65ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SW_AGENT_COLLECTOR_IS_RESOLVE_DNS_PERIODICALLY+SW_AGENT_COLLECTOR_GRPC_CHANNEL_CHECK_INTERVAL(Javacollector.is_resolve_dns_periodically/grpc_channel_check_intervalparity).ipv4:/ipv6:dial targets and are re-checked on the interval; a changed IP set rebuilds the pick_first gRPC channel (sync daemon thread + aio watch task).Test plan
tests/unit/test_dns_reresolve.py(plain vs force-expand, fingerprint stability, protocol rebuild)TestGrpcBackendAddressdual-stack expectation updated for sorted expand orderNote: Fork-internal only; not for apache/skywalking-python upstream.