Skip to content

fix(ios): relayout inline images when dimensions are known #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hejsztynx wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix(ios): relayout inline images when dimensions are known #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ios/EnrichedTextView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ NS_ASSUME_NONNULL_BEGIN
- (void)emitOnLinkPressEvent:(NSString *)url;
- (void)emitOnMentionPressEvent:(MentionParams *)mention;
- (void)emitOnImagePressEvent:(MediaAttachment *)attachment;
- (void)layoutAttachments;
@end

NS_ASSUME_NONNULL_END
Expand Down
11 changes: 11 additions & 0 deletions ios/enrichedTextTextView/EnrichedTextTextView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@

@implementation EnrichedTextTextView

- (void)layoutSubviews {
[super layoutSubviews];

// once the textView actually knows its width and height,
// we can position the inline images
EnrichedTextView *host = self.host;
if (!CGRectIsEmpty(host.textView.frame)) {
[host layoutAttachments];
Comment thread
hejsztynx marked this conversation as resolved.
}
}

- (void)copy:(id)sender {
EnrichedTextView *host = self.host;
if (host == nullptr) {
Expand Down
Loading