Skip to content

fix(landing): serve pre-encoded footer artwork - #7667

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/footer-static-artwork
Sep 9, 2026
Merged

fix(landing): serve pre-encoded footer artwork#7667
waleedlatif1 merged 1 commit into
stagingfrom
codex/footer-static-artwork

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Serve responsive, pre-encoded AVIF/WebP footer artwork directly so the first visitor does not wait for request-time image conversion.
  • Preserve the existing artwork, 4K option, theme selection, lazy loading, blur preview, and layout. Add content-hashed assets with immutable caching and a repeatable generator.

Type of Change

  • Bug fix

Testing

  • Five focused tests passed, including asset dimensions, content hashes, and static image delivery.
  • Type checking, lint, all 46 audits, block registry validation, and docs manifest verification passed.
  • Checked both themes across mobile, tablet, and desktop widths, including responsive source selection and hidden-theme loading. The generated 4K light AVIF matches the current optimizer output byte for byte.
  • Production build not run. Deployed request timings remain to be verified after deployment.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 9, 2026 7:06pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR replaces request-time optimization of landing-page footer artwork with responsive, pre-encoded AVIF/WebP assets and adds immutable caching plus a repeatable generator.

  • Adds content-hashed artwork variants and a generated source-set manifest.
  • Updates the CTA to serve responsive static sources while retaining theme selection, blur previews, and layout behavior.
  • Adds asset-integrity and rendering tests.
  • Adds a scoped immutable cache policy for generated artwork.
  • One repository import-order violation remains.

Confidence Score: 4/5

The functional change appears sound, but the explicit repository import-order requirement must be satisfied before merging.

No behavioral or security failure was established; the sole accepted finding is the new feature import being placed after the CSS import.

Files Needing Attention: apps/sim/app/(landing)/components/cta/cta.tsx

Important Files Changed

Filename Overview
apps/sim/app/(landing)/components/cta/cta.tsx Replaces optimized theme images with responsive pre-encoded picture sources; the new feature import is incorrectly placed after the CSS import.
apps/sim/app/(landing)/components/cta/footer-artwork.generated.ts Defines content-hashed AVIF/WebP source sets, fallbacks, and embedded blur previews for both themes.
apps/sim/next.config.ts Adds a scoped one-year immutable cache policy for generated footer artwork.
scripts/generate-footer-artwork.ts Generates responsive encoded variants, hashes filenames, writes the manifest, formats it, and removes stale generated assets.
apps/sim/app/(landing)/components/cta/cta.test.tsx Verifies static responsive rendering, dimensions, content hashes, lazy loading, and optimizer bypass.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  M[Light and dark master WebP files] --> G[Footer artwork generator]
  G --> A[Hashed AVIF and WebP variants]
  G --> F[Generated source-set manifest]
  F --> C[Landing CTA picture elements]
  C --> B[Browser selects format and width]
  A --> B
  H[Next.js immutable cache headers] --> A
Loading

Reviews (1): Last reviewed commit: "fix(landing): serve pre-encoded footer a..." | Re-trigger Greptile

Comment thread apps/sim/app/(landing)/components/cta/cta.tsx
@waleedlatif1
waleedlatif1 merged commit e508098 into staging Sep 9, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/footer-static-artwork branch September 9, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant