fix(landing): serve pre-encoded footer artwork - #7667
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR replaces request-time optimization of landing-page footer artwork with responsive, pre-encoded AVIF/WebP assets and adds immutable caching plus a repeatable generator.
Confidence Score: 4/5The functional change appears sound, but the explicit repository import-order requirement must be satisfied before merging. No behavioral or security failure was established; the sole accepted finding is the new feature import being placed after the CSS import. Files Needing Attention: apps/sim/app/(landing)/components/cta/cta.tsx
|
| Filename | Overview |
|---|---|
| apps/sim/app/(landing)/components/cta/cta.tsx | Replaces optimized theme images with responsive pre-encoded picture sources; the new feature import is incorrectly placed after the CSS import. |
| apps/sim/app/(landing)/components/cta/footer-artwork.generated.ts | Defines content-hashed AVIF/WebP source sets, fallbacks, and embedded blur previews for both themes. |
| apps/sim/next.config.ts | Adds a scoped one-year immutable cache policy for generated footer artwork. |
| scripts/generate-footer-artwork.ts | Generates responsive encoded variants, hashes filenames, writes the manifest, formats it, and removes stale generated assets. |
| apps/sim/app/(landing)/components/cta/cta.test.tsx | Verifies static responsive rendering, dimensions, content hashes, lazy loading, and optimizer bypass. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
M[Light and dark master WebP files] --> G[Footer artwork generator]
G --> A[Hashed AVIF and WebP variants]
G --> F[Generated source-set manifest]
F --> C[Landing CTA picture elements]
C --> B[Browser selects format and width]
A --> B
H[Next.js immutable cache headers] --> A
Reviews (1): Last reviewed commit: "fix(landing): serve pre-encoded footer a..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist