Skip to content

fix(settings): show connected accounts without search - #7665

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
codex/credential-groups-local
Sep 9, 2026
Merged

fix(settings): show connected accounts without search#7665
TheodoreSpeaks merged 1 commit into
stagingfrom
codex/credential-groups-local

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Show Connected accounts under Organization in normal settings when credential groups are enabled and Search is disabled.
  • Reuse organization-scoped accounts and admin authorization. Search-enabled organizations keep the Sources UI.

Type of Change

  • Bug fix

Testing

  • 128 focused settings, navigation, authorization, and feature-flag tests pass.
  • App and auth type-checks, repository lint, and all 46 CI audits pass.
  • Verified the page in the browser with Search disabled, organization-scoped accounts loading successfully, and Search execution denied.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 9, 2026 6:43pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds organization Connected Accounts to the unified workspace settings catalog for organizations where credential groups are enabled and Search is disabled.

  • Renders the existing organization-scoped Connected Accounts component within workspace settings.
  • Restricts sidebar visibility to organization admins and owners under the intended feature combination.
  • Reuses organization-section authorization for direct route access.
  • Extends navigation, access-control, and routing tests for the new section.

Confidence Score: 5/5

The PR appears safe to merge, with navigation visibility, route authorization, organization scope, and feature gates aligned.

No actionable failures remain: the new section uses the same organization scope and authorization as the existing component, while client visibility and server access consistently enforce administrator access, credential-group availability, and disabled organization Search.

Important Files Changed

Filename Overview
apps/sim/lib/settings/application/workspace-section-access.ts Delegates Connected Accounts access to the existing organization-scoped authorization boundary.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-sidebar/settings-sidebar.tsx Shows Connected Accounts only to organization administrators when credential groups are available and organization Search is disabled.
apps/sim/components/settings/navigation.ts Registers Connected Accounts as an organization-group section in unified settings navigation.
apps/sim/app/workspace/[workspaceId]/settings/[section]/settings.tsx Renders the existing organization-scoped Connected Accounts component using the routed workspace’s host organization.
apps/sim/lib/settings/application/workspace-section-access.test.ts Covers authorization across credential-group, Search, organization, and administrator-access combinations.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Open workspace settings] --> B{Connected accounts section?}
  B -- No --> C[Existing settings flow]
  B -- Yes --> D{Organization admin or owner?}
  D -- No --> E[Hide link / redirect to General]
  D -- Yes --> F{Credential groups enabled?}
  F -- No --> E
  F -- Yes --> G{Organization Search enabled?}
  G -- Yes --> H[Keep organization Sources UI]
  G -- No --> I[Show workspace Connected accounts]
  I --> J[Render organization-scoped accounts]
Loading

Reviews (1): Last reviewed commit: "fix(settings): show connected accounts w..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit 9ac3cea into staging Sep 9, 2026
33 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/credential-groups-local branch September 9, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant