fix(settings): show connected accounts without search - #7665
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR adds organization Connected Accounts to the unified workspace settings catalog for organizations where credential groups are enabled and Search is disabled.
Confidence Score: 5/5The PR appears safe to merge, with navigation visibility, route authorization, organization scope, and feature gates aligned. No actionable failures remain: the new section uses the same organization scope and authorization as the existing component, while client visibility and server access consistently enforce administrator access, credential-group availability, and disabled organization Search.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/settings/application/workspace-section-access.ts | Delegates Connected Accounts access to the existing organization-scoped authorization boundary. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-sidebar/settings-sidebar.tsx | Shows Connected Accounts only to organization administrators when credential groups are available and organization Search is disabled. |
| apps/sim/components/settings/navigation.ts | Registers Connected Accounts as an organization-group section in unified settings navigation. |
| apps/sim/app/workspace/[workspaceId]/settings/[section]/settings.tsx | Renders the existing organization-scoped Connected Accounts component using the routed workspace’s host organization. |
| apps/sim/lib/settings/application/workspace-section-access.test.ts | Covers authorization across credential-group, Search, organization, and administrator-access combinations. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Open workspace settings] --> B{Connected accounts section?}
B -- No --> C[Existing settings flow]
B -- Yes --> D{Organization admin or owner?}
D -- No --> E[Hide link / redirect to General]
D -- Yes --> F{Credential groups enabled?}
F -- No --> E
F -- Yes --> G{Organization Search enabled?}
G -- Yes --> H[Keep organization Sources UI]
G -- No --> I[Show workspace Connected accounts]
I --> J[Render organization-scoped accounts]
Reviews (1): Last reviewed commit: "fix(settings): show connected accounts w..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist