fix(pptx): initialize isolated embedded PDF renderer - #7661
Open
BillLeoutsakosvl346 wants to merge 2 commits into
Open
fix(pptx): initialize isolated embedded PDF renderer#7661BillLeoutsakosvl346 wants to merge 2 commits into
BillLeoutsakosvl346 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Contributor
Author
|
@greptile Please reassess the resolved testing-scope thread using the documented production-built browser verification. No code changes were necessary; automated unit coverage and manual real-worker coverage are explicitly distinguished. |
Contributor
Author
|
@cubic-dev-ai review this PR |
Contributor
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Restore the resolve-once memoization for the pdfjs asset URLs so the failure path is not retried per embedded PDF, matching the documented intent of the cache. Execute WORKER_SRC in-process against a stand-in pdfjs so the fix itself is covered rather than only the message it posts. The worker template was previously an untested string, which is how the falsy workerSrc assignment shipped green. Asserts that the worker module is imported before the library and that GlobalWorkerOptions is never written to. Also fixes the canvas-guard test, which passed because window was undefined rather than because the guard fired, and adds the missing Worker guard case. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTTSjsX7CBMfXrdmq4PL85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist