Skip to content

fix(docs): preserve tool outputs and nullable types - #7657

Open
BillLeoutsakosvl346 wants to merge 3 commits into
stagingfrom
fix/platform-docs-accuracy
Open

fix(docs): preserve tool outputs and nullable types#7657
BillLeoutsakosvl346 wants to merge 3 commits into
stagingfrom
fix/platform-docs-accuracy

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Use evaluated tool outputs when source extraction is empty, preserving existing nonempty-source precedence.
  • Preserve nullable output types and clean generated template/EOF whitespace without changing manual Markdown.
  • Regenerate 271 integration pages: 218 whitespace-only, 40 nullable-only, and 13 with corrected output schemas. Generator logic and tests are the only handwritten changes.

Type of Change

  • Bug fix

Testing

  • 84 documentation-generator tests pass, including actual tool-to-rendered-table regressions and manual hard-break preservation.
  • App type-check, repository lint, all 46 audits, block-registry/migration checks, docs-manifest check, and diff check pass.
  • Confirmed all existing manual-content sections remain byte-identical. No new lint warnings; three existing parser-fixture warnings remain.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 9, 2026 6:12pm UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile-apps Please review this PR. Most changed files are canonical generated documentation; the handwritten changes are scripts/generate-docs.ts and its existing test suite.

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the latest revision resolves the prior nullable-spread and exported-helper documentation findings without introducing a new actionable issue.

Summary

  • Adds concise TSDoc for mergeWithManualContent and generateMarkdownForBlock.
  • Preserves explicit nullable overrides on resolved output-schema spreads.
  • Regenerates integration documentation with corrected nullable types and normalized generated whitespace.
  • Keeps manual Markdown sections preserved during regeneration.

Comment thread scripts/generate-docs.ts
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile-apps Please review the nullable spread fix on the latest head.

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

Comment thread scripts/generate-docs.ts
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile-apps Please review the latest head, including TSDoc for the exported helpers.

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant