fix(docs): describe which surfaces the NEXT_PUBLIC_ flag twins still gate - #7465
Merged
Conversation
…gate The workspace host context now carries the server-resolved deployment shape, so settings sections and block fields inside a workspace follow the server variable. The NEXT_PUBLIC_ twins still gate the login page's SSO entry point and the Function block's Sandbox selector, and sim-setup doctor checks each pair. Update the sentences that said the twin decides what the settings UI shows. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR clarifies which settings and block surfaces use server-resolved deployment configuration and which remain gated by browser-side
Confidence Score: 5/5The documentation changes appear safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/docs/content/docs/platform/self-hosting/sandboxes.mdx | The revised visibility and readiness descriptions align with the current Sandboxes navigation and Function-block behavior. |
| apps/docs/content/docs/platform/enterprise/self-hosted.mdx | The guide now distinguishes server-resolved workspace surfaces from the remaining browser-side gates. |
| apps/docs/content/docs/platform/self-hosting/security.mdx | The Sandbox security guidance consistently describes Shell, settings, and selector gating. |
Reviews (4): Last reviewed commit: "fix(docs): state the resolved flag condi..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…scope The Sandboxes settings entry keeps its sidebar row and shows an upgrade notice until the server's readiness check passes, so say that instead of claiming the section is hidden, and add a troubleshooting bullet for that state. Describe NEXT_PUBLIC_SANDBOXES_ENABLED as an assertion the operator makes rather than a copy of readiness, invoke the setup doctor as npx sim-setup doctor throughout, and qualify its diagnostic mentions to Compose installs and source checkouts. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…Sandbox check ENTERPRISE_ENABLED resolves data drains and the Sandbox entitlement on without the per-feature flag, so describe the off state as the feature resolving off rather than the flag being unset. The setup doctor compares NEXT_PUBLIC_SANDBOXES_ENABLED with the selected provider's readiness rather than with SANDBOXES_ENABLED, so say that instead of promising a pair check. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…r exception Describe the Sandbox entitlement by how the flags resolve, since an explicit SANDBOXES_ENABLED=false overrides the master switch. Say an unset or false twin hides the login page's SSO entry point and the Sandbox selector, name that selector as the one block field that still reads the browser's own configuration, and scope the remaining setup doctor mentions to Compose installs and source checkouts. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NEXT_PUBLIC_flag twins decide what the settings UI shows. Since fix(config): resolve the deployment shape on the server and read it through one client reader #7461 a workspace reads the server-resolved deployment configuration, so settings sections and block fields follow the server variable. The twins still gate what renders before a workspace loads: the login page's SSO entry point and the Function block's Sandbox selector.sim-setup doctorchecks each pair.NEXT_PUBLIC_SANDBOXES_ENABLEDdescriptions in the Sandboxes, Security, and Environment variables pages, and the data drains and verified domains notes that credited the twin with showing or hiding a settings page.Type of Change
Testing
bun run type-checkinapps/docs(fumadocs-mdx compile),bun run lint,bun run check:audits,bun run docs-manifest:checkall passChecklist