Skip to content

fix(ui): drop the overlay shadow class that never rendered before v4 - #7460

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/tile-shadow-regression
Sep 3, 2026
Merged

fix(ui): drop the overlay shadow class that never rendered before v4#7460
waleedlatif1 merged 1 commit into
stagingfrom
fix/tile-shadow-regression

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

shadow-[var(--shadow-overlay)] never rendered a shadow before the Tailwind v4 upgrade. v4 honours it, so eight surfaces silently gained a 0 10px 30px drop shadow — visible as the shadowed integrations tile grid. This removes the class so those surfaces render exactly as they do in production.

Why it only appeared now

Tailwind v3 could not tell whether a bare var() after shadow- was a shadow or a shadow colour, and resolved it as a colour:

/* v3 — compiled from shadow-[var(--shadow-overlay)] */
.shadow-\[var\(--shadow-overlay\)\] {
  --tw-shadow-color: var(--shadow-overlay);
  --tw-shadow: var(--tw-shadow-colored);   /* 0 0 #0000 — draws nothing */
}
/* v4 — same class */
.shadow-\[var\(--shadow-overlay\)\] {
  --tw-shadow: var(--shadow-overlay);      /* 0 10px 30px rgba(0,0,0,0.11) */
}

Both were verified by compiling the class through each engine, not inferred. The class was dead in production, so the shadow it describes was never reviewed on any of these surfaces.

The named shadow-overlay utility — the one chart-tooltip, consent-banner and the table sidebars use — always worked correctly and is untouched here.

Surfaces restored to their production rendering

integrations-showcase, chip-modal (emcn), toast (emcn), search-modal, nav-menu-chip, status-notice, hero-visual, stage-kb.

A status-notice test asserted the class was present. It was pinning a no-op, so it is removed rather than inverted.

If the shadows are wanted

This restores parity, it does not decide the design. Any of these surfaces can opt in deliberately by switching to the working shadow-overlay utility — a modal or toast drop shadow is a reasonable thing to want, it just has never shipped and should be a design call rather than a side effect of a dependency upgrade.

Type of Change

  • Bug fix

Testing

  • Compiled apps/sim/app/_styles/globals.css before and after: the .shadow-[var(--shadow-overlay)] rule is emitted before the change and absent after, matching production's effective rendering.
  • Compiled the same class through Tailwind v3 to confirm it resolved to a shadow colour and drew nothing.
  • Full suite, bun run check:audits, bunx turbo run type-check, bun run lint, bun run docs-manifest:check.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 3, 2026 10:30pm UTC

Request Review

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Restores pre-Tailwind-v4 rendering by removing an arbitrary shadow class that became effective only after the upgrade.

  • Removes shadow-[var(--shadow-overlay)] from eight landing, workspace, modal, notice, and toast surfaces.
  • Removes the obsolete StatusNotice test assertion that required the previously ineffective class.
  • Leaves the intentional shadow-overlay utility and its existing consumers unchanged.

Confidence Score: 5/5

The PR appears safe to merge because it consistently removes a newly activated visual effect while preserving component structure and behavior.

The changes are limited to deleting the same arbitrary shadow utility and its obsolete test assertion, with no concrete functional, security, or repository-rule failure identified.

Important Files Changed

Filename Overview
apps/sim/app/(landing)/components/hero/components/hero-visual/hero-visual.tsx Removes the newly effective overlay shadow from the animated knowledge-base shell without changing its layout or behavior.
apps/sim/app/(landing)/components/hero/components/hero-visual/stage-kb.tsx Removes the arbitrary overlay shadow from the standalone knowledge-base panel.
apps/sim/app/(landing)/components/navbar/components/nav-menu-chip/nav-menu-chip.tsx Restores the navigation menu panel's previously shipped unshadowed appearance.
apps/sim/app/workspace/[workspaceId]/integrations/components/integrations-showcase/integrations-showcase.tsx Removes the unintended shadow from the decorative integrations showcase container.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx Removes the newly rendered shadow while retaining the modal's border, background, positioning, and visibility behavior.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/status-notice/status-notice.tsx Removes the unintended status-notice shadow while preserving its border and status-specific background.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/status-notice/status-notice.test.tsx Removes the obsolete assertion for the deleted no-op class while retaining assertions for meaningful status styling.
packages/emcn/src/components/chip-modal/chip-modal.tsx Restores the shared chip modal's previously shipped unshadowed rendering.
packages/emcn/src/components/toast/toast.tsx Restores toast rendering parity without changing geometry, interaction, or content layout.

Reviews (1): Last reviewed commit: "fix(ui): drop the overlay shadow class t..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 0664c6f into staging Sep 3, 2026
31 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/tile-shadow-regression branch September 3, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant