fix(ui): drop the overlay shadow class that never rendered before v4 - #7460
Conversation
|
@cubic-dev-ai review this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Greptile SummaryRestores pre-Tailwind-v4 rendering by removing an arbitrary shadow class that became effective only after the upgrade.
Confidence Score: 5/5The PR appears safe to merge because it consistently removes a newly activated visual effect while preserving component structure and behavior. The changes are limited to deleting the same arbitrary shadow utility and its obsolete test assertion, with no concrete functional, security, or repository-rule failure identified.
|
| Filename | Overview |
|---|---|
| apps/sim/app/(landing)/components/hero/components/hero-visual/hero-visual.tsx | Removes the newly effective overlay shadow from the animated knowledge-base shell without changing its layout or behavior. |
| apps/sim/app/(landing)/components/hero/components/hero-visual/stage-kb.tsx | Removes the arbitrary overlay shadow from the standalone knowledge-base panel. |
| apps/sim/app/(landing)/components/navbar/components/nav-menu-chip/nav-menu-chip.tsx | Restores the navigation menu panel's previously shipped unshadowed appearance. |
| apps/sim/app/workspace/[workspaceId]/integrations/components/integrations-showcase/integrations-showcase.tsx | Removes the unintended shadow from the decorative integrations showcase container. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx | Removes the newly rendered shadow while retaining the modal's border, background, positioning, and visibility behavior. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/status-notice/status-notice.tsx | Removes the unintended status-notice shadow while preserving its border and status-specific background. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/status-notice/status-notice.test.tsx | Removes the obsolete assertion for the deleted no-op class while retaining assertions for meaningful status styling. |
| packages/emcn/src/components/chip-modal/chip-modal.tsx | Restores the shared chip modal's previously shipped unshadowed rendering. |
| packages/emcn/src/components/toast/toast.tsx | Restores toast rendering parity without changing geometry, interaction, or content layout. |
Reviews (1): Last reviewed commit: "fix(ui): drop the overlay shadow class t..." | Re-trigger Greptile
Summary
shadow-[var(--shadow-overlay)]never rendered a shadow before the Tailwind v4 upgrade. v4 honours it, so eight surfaces silently gained a0 10px 30pxdrop shadow — visible as the shadowed integrations tile grid. This removes the class so those surfaces render exactly as they do in production.Why it only appeared now
Tailwind v3 could not tell whether a bare
var()aftershadow-was a shadow or a shadow colour, and resolved it as a colour:Both were verified by compiling the class through each engine, not inferred. The class was dead in production, so the shadow it describes was never reviewed on any of these surfaces.
The named
shadow-overlayutility — the onechart-tooltip,consent-bannerand the table sidebars use — always worked correctly and is untouched here.Surfaces restored to their production rendering
integrations-showcase,chip-modal(emcn),toast(emcn),search-modal,nav-menu-chip,status-notice,hero-visual,stage-kb.A
status-noticetest asserted the class was present. It was pinning a no-op, so it is removed rather than inverted.If the shadows are wanted
This restores parity, it does not decide the design. Any of these surfaces can opt in deliberately by switching to the working
shadow-overlayutility — a modal or toast drop shadow is a reasonable thing to want, it just has never shipped and should be a design call rather than a side effect of a dependency upgrade.Type of Change
Testing
apps/sim/app/_styles/globals.cssbefore and after: the.shadow-[var(--shadow-overlay)]rule is emitted before the change and absent after, matching production's effective rendering.bun run check:audits,bunx turbo run type-check,bun run lint,bun run docs-manifest:check.Checklist