feat(oci): add native foundation - #7444
Open
BillLeoutsakosvl346 wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR establishes a server-only OCI API-key credential foundation.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains in the eligible follow-up review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/credentials/oci-api-key-service-account.server.ts | Adds strict OCI credential validation, verification, encryption, serialization, and provider-bound loading; no eligible follow-up finding was established. |
| apps/sim/lib/internal/oci/client.server.ts | Adds bounded, redirect-free OCI request transport using the repository’s guarded fetch boundary. |
| apps/sim/lib/internal/oci/endpoints.ts | Adds a snapshotted OCI region and realm registry with exact service-owned endpoint validation. |
| apps/sim/lib/internal/oci/signing.server.ts | Adds in-memory OCI HTTP request signing while reserving signer-controlled headers. |
| apps/sim/lib/internal/oci/errors.ts | Adds bounded OCI error parsing and redaction of request and credential material. |
| apps/sim/lib/oauth/types.ts | Adds OCI API-key service-account provider and secret type identifiers. |
| apps/sim/package.json | Adds the pinned OCI common dependency used by the native signer. |
| bun.lock | Records the pinned OCI dependency resolution. |
Sequence Diagram
sequenceDiagram
participant Caller
participant Credential as OCI Credential Service
participant Signer as OCI Request Signer
participant Transport as Guarded Transport
participant OCI as OCI Object Storage
Caller->>Credential: Submit API-key fields
Credential->>Credential: Validate OCIDs, region, RSA key, fingerprint
Credential->>Signer: Sign GetNamespace request in memory
Signer->>Transport: Signed URL, headers, and bounds
Transport->>OCI: HTTPS request without redirects
OCI-->>Transport: Bounded response
Transport-->>Credential: Namespace or sanitized error
Credential->>Credential: Encrypt validated secret
Credential-->>Caller: Encrypted credential and namespace
Reviews (2): Last reviewed commit: "fix(oci): harden endpoint and error vali..." | Re-trigger Greptile
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
BillLeoutsakosvl346
force-pushed
the
feat/oci-foundation
branch
from
September 3, 2026 20:40
d7a3b4f to
d2d066d
Compare
Contributor
Author
|
@greptile review this PR |
Contributor
Author
|
@cubic-dev-ai review this PR |
Contributor
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
BillLeoutsakosvl346
force-pushed
the
feat/oci-foundation
branch
from
September 3, 2026 21:10
d2d066d to
77e26a0
Compare
Contributor
Author
|
@greptile review this PR |
Contributor
Author
|
@cubic-dev-ai review this PR |
Contributor
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist
Screenshots/Videos
Not applicable; this change is server-only.