fix(combobox): initialize virtualized options on open - #7443
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR replaces the combobox’s mutable scroll-area ref with state so the virtualizer is updated when the popover’s scroll container mounts.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or test-isolation issues identified. The mounted scroll element now causes the virtualizer to reconfigure, while regression tests cover portal behavior, reopening, keyboard interaction, scrolling, and filtering; existing cleanup restores the added prototype spies after every test.
|
| Filename | Overview |
|---|---|
| packages/emcn/src/components/combobox/combobox.tsx | Replaces the scroll-area ref with state and supplies the mounted element to the virtualizer; no actionable defect was identified. |
| packages/emcn/src/components/combobox/combobox.dom.test.tsx | Adds focused virtualized-combobox regression coverage with prototype mocks that are restored by the existing test cleanup. |
Reviews (1): Last reviewed commit: "fix(combobox): initialize virtualized op..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist