Skip to content

fix(combobox): initialize virtualized options on open - #7443

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/diagnose-blank-model-dropdown
Sep 3, 2026
Merged

fix(combobox): initialize virtualized options on open#7443
waleedlatif1 merged 1 commit into
stagingfrom
codex/diagnose-blank-model-dropdown

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Initialize virtualized combobox options when the popover scroll container mounts.
  • Add regression coverage for large lists, portals, reopening, keyboard selection, scrolling, and filtering.

Type of Change

  • Bug fix

Testing

  • Confirmed six new cases fail before the fix and pass afterward.
  • Shared-component suite: 185 tests passed; TypeScript passed.
  • Real-browser fixture with production component/CSS: first open, reopen, last-row scrolling/selection, filtering, and editable keyboard selection passed.
  • Cleanup review, lint, all 45 repository audits, API validation, and docs manifest checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 3, 2026 8:08pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR replaces the combobox’s mutable scroll-area ref with state so the virtualizer is updated when the popover’s scroll container mounts.

  • Initializes virtualized options on first open and reopening, with and without a portal.
  • Adds coverage for keyboard selection, scrolling beyond the initial window, and filtering across the virtualization threshold.
  • Adds deterministic JSDOM element dimensions for virtualizer testing.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or test-isolation issues identified.

The mounted scroll element now causes the virtualizer to reconfigure, while regression tests cover portal behavior, reopening, keyboard interaction, scrolling, and filtering; existing cleanup restores the added prototype spies after every test.

Important Files Changed

Filename Overview
packages/emcn/src/components/combobox/combobox.tsx Replaces the scroll-area ref with state and supplies the mounted element to the virtualizer; no actionable defect was identified.
packages/emcn/src/components/combobox/combobox.dom.test.tsx Adds focused virtualized-combobox regression coverage with prototype mocks that are restored by the existing test cleanup.

Reviews (1): Last reviewed commit: "fix(combobox): initialize virtualized op..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit cdc6973 into staging Sep 3, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/diagnose-blank-model-dropdown branch September 3, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant