Skip to content

fix(chat): restore assistant feedback actions - #7438

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-chat-feedback-actions
Sep 3, 2026
Merged

fix(chat): restore assistant feedback actions#7438
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-chat-feedback-actions

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Restore the preceding user query when rendering assistant message actions
  • Require explicit feedback-query plumbing so missing call-site data fails type-checking

Type of Change

  • Bug fix

Testing

  • Targeted Vitest suite
  • Sim app type-check
  • Lint and repository audit suite

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 3, 2026 6:06pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR restores assistant feedback actions by explicitly pairing each assistant message with the preceding user message.

  • Makes the feedback query prop required at MessageActions call sites while retaining undefined as an explicit value.
  • Computes preceding user content for each transcript row and passes it to assistant message actions.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or non-blocking defects identified.

The new transcript scan correctly supplies the immediately preceding user content to assistant feedback actions, while assistant messages lacking a user query continue to suppress feedback submission.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/components/message-actions/message-actions.tsx Requires callers to explicitly provide the feedback query without changing runtime submission behavior.
apps/sim/app/workspace/[workspaceId]/home/components/mothership-chat/mothership-chat.tsx Derives each assistant row's feedback query from the latest preceding user message and threads it into MessageActions.

Reviews (1): Last reviewed commit: "fix(chat): restore assistant feedback ac..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 17bfb0b into staging Sep 3, 2026
29 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-chat-feedback-actions branch September 3, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant