Skip to content

fix(dependencies): update Tiptap to patched release - #7431

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-tiptap-prototype-pollution
Sep 3, 2026
Merged

fix(dependencies): update Tiptap to patched release#7431
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-tiptap-prototype-pollution

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Update the aligned TipTap packages to 3.30.5 to include the mergeAttributes prototype-pollution fix
  • Keep ProseMirror deduplicated and align editor integration tests with the current EditorContent lifecycle

Type of Change

  • Bug fix

Testing

  • bun run lint
  • bun run check:audits
  • bun run apps/sim/scripts/check-block-registry.ts origin/staging
  • bun run type-check in apps/sim
  • 478 TipTap-related tests
  • Prototype-pollution regression check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner September 3, 2026 05:57
@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 3, 2026 5:59am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the aligned TipTap packages from 3.26.1 to 3.30.5 for the patched mergeAttributes behavior and updates editor integration tests for the current React EditorContent lifecycle.

  • Keeps the TipTap and ProseMirror dependency graph consistently resolved.
  • Mounts raw-markdown node-view tests through a real React editor tree.
  • Adjusts dirty-on-open coverage to accept a clean mount with no update event.

Confidence Score: 5/5

The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified.

The TipTap packages and lockfile are aligned, ProseMirror remains consistently resolved, and the test lifecycle changes match the current clean-mount and React node-view behavior.

Important Files Changed

Filename Overview
apps/sim/package.json Aligns the directly declared TipTap package family on version 3.30.5.
bun.lock Regenerates the resolved TipTap dependency graph while retaining a deduplicated compatible ProseMirror runtime.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/raw-markdown-snippet-view.test.ts Mounts EditorContent through React so integration assertions exercise live React node views and clean up their root.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/dirty-on-open.test.ts Revises the regression assertion to verify that no mount-time update diverges from the normalized baseline.

Reviews (1): Last reviewed commit: "fix(dependencies): update Tiptap to patc..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 4b1605b into staging Sep 3, 2026
32 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-tiptap-prototype-pollution branch September 3, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant