Skip to content

feat(workspace): support GIF logos - #7322

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/support-gif-workspace-images
Sep 1, 2026
Merged

feat(workspace): support GIF logos#7322
waleedlatif1 merged 1 commit into
stagingfrom
codex/support-gif-workspace-images

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • allow GIF files in the workspace logo picker and validation
  • reuse one accepted-format definition for selection and validation

Type of Change

  • New feature

Testing

  • bun run --cwd apps/sim test -- app/workspace/[workspaceId]/w/components/sidebar/hooks/workspace-logo-file.test.ts
  • bun run lint
  • bun run check:audits
  • bun run apps/sim/scripts/check-block-registry.ts origin/staging

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Aug 31, 2026 11:56pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds GIF support to workspace logos and centralizes the picker and validation formats so they remain consistent.

  • Adds image/gif to workspace-logo selection and validation.
  • Extracts shared logo file-size and MIME-type validation.
  • Adds focused tests for GIF acceptance, size limits, and validation messaging.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

GIF is consistently accepted by the picker, client validator, existing upload-session validation, raw asset-serving path, and native image renderers.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/hooks/workspace-logo-file.ts Defines the shared 5 MB limit, accepted image MIME types including GIF, picker value, and validation behavior.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/hooks/use-workspace-logo-upload.ts Replaces duplicate inline validation with the shared workspace-logo validator while preserving the upload flow.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx Uses the shared accepted-format value for the hidden workspace-logo file picker.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/hooks/workspace-logo-file.test.ts Covers GIF selection and validation alongside the existing size and unsupported-format behavior.

Reviews (1): Last reviewed commit: "feat(workspace): support GIF logos" | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit bd75254 into staging Sep 1, 2026
27 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/support-gif-workspace-images branch September 1, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant