test: serval admin: clarify the non-null initial emit in date range picker - #4080
Open
marksvc wants to merge 1 commit into
Open
test: serval admin: clarify the non-null initial emit in date range picker#4080marksvc wants to merge 1 commit into
marksvc wants to merge 1 commit into
Conversation
marksvc
marked this pull request as draft
August 31, 2026 17:22
marksvc
marked this pull request as ready for review
August 31, 2026 17:28
Collaborator
Author
|
@RaymondLuong3 I made an adjustment to the test from your #4024. What do you think about this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4080 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 670 670
Lines 43465 43465
Branches 7131 7104 -27
=======================================
Hits 35319 35319
- Misses 6961 6976 +15
+ Partials 1185 1170 -15 ☔ View full report in Codecov by Harness. |
pmachapman
force-pushed
the
task/drp-test
branch
from
August 31, 2026 20:20
b066977 to
3338fec
Compare
…icker Test "should not emit undefined for a range if the default is defined" starts listening for emits after the a non-null date range is emitted, and it could be misleading to then assert that there was no emit. This patch changes the test to start listening earlier, and assert that there was a non-null emit, which will hopefully make it more plain. Follow-up to #4024.
pmachapman
force-pushed
the
task/drp-test
branch
from
September 6, 2026 20:51
3338fec to
efe66eb
Compare
Contributor
|
📸 Screenshot diff deployed! (1 change) View the visual diff at: https://pr-4080--sf-screenshot-diffs.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test "should not emit undefined for a range if the default is defined"
starts listening for emits after the a non-null date range is emitted,
and it could be misleading to then assert that there was no emit.
This patch changes the test to start listening earlier, and assert
that there was a non-null emit, which will hopefully make it more
plain.
Follow-up to #4024.
Open in Devin Review
This change is