SF-3920 Fix event metrics not being recorded for BuildCompletedAsync - #4079
Open
pmachapman wants to merge 1 commit into
Open
SF-3920 Fix event metrics not being recorded for BuildCompletedAsync#4079pmachapman wants to merge 1 commit into
pmachapman wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4079 +/- ##
=======================================
Coverage 81.25% 81.26%
=======================================
Files 670 670
Lines 43467 43473 +6
Branches 7132 7126 -6
=======================================
+ Hits 35321 35328 +7
+ Misses 6976 6960 -16
- Partials 1170 1185 +15 ☔ View full report in Codecov by Harness. |
pmachapman
force-pushed
the
fix/SF-3920
branch
from
September 6, 2026 21:33
a4f7429 to
c130697
Compare
Contributor
|
📸 Screenshot diff deployed! (1 change) View the visual diff at: https://pr-4079--sf-screenshot-diffs.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug I noticed on live where the following error was being logged in the journal:
This error doesn't prevent builds from completing, but will prevent the recording of the BuildCompletedAsync event metric.
This change is