SF-2956 Fix import question dialog offline error message color - #3918
SF-2956 Fix import question dialog offline error message color#3918Nateowami wants to merge 1 commit into
Conversation
|
This is reviewable in Devin Review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3918 +/- ##
=======================================
Coverage 81.30% 81.30%
=======================================
Files 670 670
Lines 43462 43462
Branches 7105 7132 +27
=======================================
Hits 35336 35336
+ Misses 6951 6936 -15
- Partials 1175 1190 +15 ☔ View full report in Codecov by Harness. |
marksvc
left a comment
There was a problem hiding this comment.
Thank you. BTW, I notice that there are a number of other mat-error element usages in this class. If the problem is that mat-error was being used outside of mat-form-field, then there are a few other places where the text will similarly not be styled as intended.
@marksvc reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Nateowami).
bc1f9be to
353f5cd
Compare
353f5cd to
24edbec
Compare
|
📸 Screenshot diff deployed! (3 changes) View the visual diff at: https://pr-3918--sf-screenshot-diffs.netlify.app |
24edbec to
d101dae
Compare
Fixes the color of the offline error messages (previously they were black).
This change is