Skip to content

SF-2956 Fix import question dialog offline error message color - #3918

Open
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-2956-question-import-dialog-offline-messages
Open

SF-2956 Fix import question dialog offline error message color#3918
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-2956-question-import-dialog-offline-messages

Conversation

@Nateowami

@Nateowami Nateowami commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes the color of the offline error messages (previously they were black).

localhost_5000_projects_6a037a701b73edc272a0c520_checking

This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Jun 1, 2026
@marksvc marksvc self-assigned this Jun 1, 2026
@marksvc

marksvc commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

This is reviewable in Devin Review.

@Nateowami
Nateowami temporarily deployed to screenshot_diff June 1, 2026 21:12 — with GitHub Actions Inactive
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.30%. Comparing base (5767261) to head (d101dae).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3918   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files         670      670           
  Lines       43462    43462           
  Branches     7105     7132   +27     
=======================================
  Hits        35336    35336           
+ Misses       6951     6936   -15     
- Partials     1175     1190   +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@marksvc marksvc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. BTW, I notice that there are a number of other mat-error element usages in this class. If the problem is that mat-error was being used outside of mat-form-field, then there are a few other places where the text will similarly not be styled as intended.

@marksvc reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@Nateowami
Nateowami marked this pull request as draft June 2, 2026 13:25
@Nateowami
Nateowami force-pushed the fix/SF-2956-question-import-dialog-offline-messages branch from bc1f9be to 353f5cd Compare August 10, 2026 16:43
@Nateowami
Nateowami deployed to screenshot_diff August 10, 2026 16:51 — with GitHub Actions Active
@Nateowami
Nateowami force-pushed the fix/SF-2956-question-import-dialog-offline-messages branch from 353f5cd to 24edbec Compare September 1, 2026 01:59
@Nateowami
Nateowami deployed to screenshot_diff September 1, 2026 02:06 — with GitHub Actions Active
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📸 Screenshot diff deployed! (3 changes)

View the visual diff at: https://pr-3918--sf-screenshot-diffs.netlify.app

@Nateowami
Nateowami force-pushed the fix/SF-2956-question-import-dialog-offline-messages branch from 24edbec to d101dae Compare September 1, 2026 02:21
@Nateowami
Nateowami deployed to screenshot_diff September 1, 2026 02:29 — with GitHub Actions Active
@Nateowami
Nateowami marked this pull request as ready for review September 1, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants