Skip to content

Fix bug with marker location prediction #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmachapman merged 1 commit into from
Sep 7, 2026
+2 −2
Merged

Fix bug with marker location prediction #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/SIL.Machine/Corpora/PlaceMarkersUsfmUpdateBlockHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ int NumAlignCrossings(int sourceIndex, int targetIndex)

int[] hypotheses = new int[] { 0, 1, 2 };
int bestHypothesis = -1;
int bestNumCrossings = 200 ^ 2;
int bestNumCrossings = 40_000; // A large number
var checkedHypotheses = new HashSet<int>();
foreach (int hypothesis in hypotheses)
{
Expand All @@ -380,7 +380,7 @@ int NumAlignCrossings(int sourceIndex, int targetIndex)
{
// If aligning with a source token that precedes the marker,
// the target token predicted to be closest to the marker is the last aligned token rather than the first
targetHypothesis = alignedTargetTokens[hypothesis < 0 ? -1 : 0];
targetHypothesis = alignedTargetTokens[hypothesis < 0 ? alignedTargetTokens.Count - 1 : 0];
}
else
{
Expand Down
Loading