LT-22738: Change the default restore option for Send/Receive data - #1125
Open
jasonleenaylor wants to merge 1 commit into
Open
LT-22738: Change the default restore option for Send/Receive data#1125jasonleenaylor wants to merge 1 commit into
jasonleenaylor wants to merge 1 commit into
Conversation
The Send/Receive checkbox in the restore dialog now follows the restore target instead of the backup contents. Restoring over the original name forces it on, because that project keeps its repository history, and restoring to a different name leaves it unchecked until the user asks for it. It stays unavailable when the backup holds no Send/Receive data. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
==========================================
+ Coverage 38.34% 38.58% +0.24%
==========================================
Files 1507 1514 +7
Lines 350586 351039 +453
Branches 40294 40360 +66
==========================================
+ Hits 134432 135465 +1033
+ Misses 186927 186359 -568
+ Partials 29227 29215 -12
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Send/Receive checkbox in the restore dialog now follows the restore
target instead of the backup contents. Restoring over the original name
forces it on, because that project keeps its repository history, and
restoring to a different name leaves it unchecked until the user asks for it.
It stays unavailable when the backup holds no Send/Receive data.
Why it needed changing
LT-22629 made the checkbox editable, but it still started checked whenever the
backup happened to contain S/R data, so the narrow expert scenario was the
default for everyone.
Simply defaulting it off would have been worse:
RestoreProjectPresenter.IsOkayToRestoreProjectrefuses to restore over aproject that is using Send/Receive when the option is off, and its message
gives no hint that ticking the box would let the restore through. Forcing the
option on for an original-name restore keeps that path working and confines
the choice to restores under a new name, which is the case the ticket is
about.
Validation
.\build.ps1 -CommentHygiene- clean..\test.ps1 -CommentHygiene -TestProject Src/FwCoreDlgs/FwCoreDlgsTests -TestFilter FullyQualifiedName~RestoreProjectPresenterTests- 3 passed.by reading the code paths.
The backup-side default is untouched; that is LT-22783.
This change is