Skip to content

Fix LT-22760 - #1123

Merged
AndyBlack merged 1 commit into
mainfrom
LT22760
Sep 4, 2026
Merged

Fix LT-22760#1123
AndyBlack merged 1 commit into
mainfrom
LT22760

Conversation

@AndyBlack

@AndyBlack AndyBlack commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Change-Id: Ia24a6d7fc28fa18d6d8983e9f2fa44aedb89216a

The fix is to use the BuildCreateNewOpenCancelDialog whenever an operations file cannot be found. Before we'd also check on the filename to see if it was null or empty before using this dialog. There's no need for that.


This change is Reviewable

Change-Id: Ia24a6d7fc28fa18d6d8983e9f2fa44aedb89216a
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   12m 42s ⏱️ + 1m 3s
6 011 tests ±0  5 930 ✅ ±0  81 💤 ±0  0 ❌ ±0 
6 020 runs  ±0  5 939 ✅ ±0  81 💤 ±0  0 ❌ ±0 

Results for commit 5245bfc. ± Comparison against base commit 1ab408b.

@codecov-commenter

codecov-commenter commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.58%. Comparing base (1ab408b) to head (5245bfc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   38.57%   38.58%           
=======================================
  Files        1514     1514           
  Lines      351014   351014           
  Branches    40355    40355           
=======================================
+ Hits       135418   135435   +17     
+ Misses     186380   186364   -16     
+ Partials    29216    29215    -1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

// Assume it was canceled, so quit
this.Dispose();
}
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintentional whitespace change

@AndyBlack
AndyBlack merged commit bc0ef50 into main Sep 4, 2026
8 checks passed
@AndyBlack
AndyBlack deleted the LT22760 branch September 4, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants