Conversation
Change-Id: I24735bad6cd9e8823a0a028151afdc64722d5a8e
Comment hygiene (advisory)No comment-style violations in the lines this branch adds since |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 38.33% 38.58% +0.24%
==========================================
Files 1507 1514 +7
Lines 350580 351027 +447
Branches 40293 40356 +63
==========================================
+ Hits 134410 135435 +1025
+ Misses 186941 186378 -563
+ Partials 29229 29214 -15
🚀 New features to boost your workflow:
|
papeh
reviewed
Sep 3, 2026
| { | ||
| case "XAmple": | ||
| m_parser = new XAmpleParser(m_cache, parserDataDir); | ||
| // LT-22708 As of 2026.08.26, this is only called within FLEx from FdoLexiconTests. |
Contributor
There was a problem hiding this comment.
how expensive would it be to keep this test code out of production code?
Collaborator
Author
There was a problem hiding this comment.
@jasonleenaylor Could you reply to this, please? I suspect that this code is used between Paratext and FLEx...
Change-Id: Ie7662021a72fe8e6f47d639d2ea4ea05dc54f3d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I24735bad6cd9e8823a0a028151afdc64722d5a8e
Using XAmple with additional properties can cause a crash per what is in https://jira.sil.org/browse/LT-22708.
This fix has the XAmple parser send a refresh message just after the new list is added. It does cause the Try a Word window to flash and then disappear while the main window also flashes but returns.
I do not know what is causing the Try a Word window to disappear although I suspect it may have to do with the parser running in a separate thread...
This change is