skills: v6.6.3 catch-up - #18
Draft
seidroid[bot] wants to merge 4 commits into
Draft
Conversation
….toml config field that stops a node before executing a target block while continuing to serve RPC, with validation constraints against halt-height/halt-time, grpc-only, state sync, seed mode, and Autobahn. (sei-protocol/sei-chain#3978)
…PC requests to live and freeze-height-frozen nodes based on block number, plus a new `--freeze-height` flag on `seid start`. (sei-protocol/sei-chain#4024)
…e-depth CLI flag (default 16) to bound nested block reference parsing depth. (sei-protocol/sei-chain#4034)
…-limit and --write-timeout, to configure JSON-RPC batch size limits and HTTP response write timeouts. (sei-protocol/sei-chain#4048)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill catch-up for v6.6.3.
4 source PR(s) produced changes across 4 commit(s). Each source PR is a separate commit, so this reviews commit-by-commit.
skill/references/cli/seid-cli.md,skill/references/ecosystem/node-operations.mdskill/references/cli/frozen-rpc-router.md,skill/references/cli/seid-cli.mdfrozen-rpc-routerbinary that proxies EVM JSON-RPC requests to live and freeze-height-frozen nodes based on block number, plus a new--freeze-heightflag onseid start.skill/references/cli/frozen-rpc-router.mdskill/references/cli/frozen-rpc-router.md⛔ Failed final verification against the release tag
Each touched page was re-checked claim-by-claim against the
v6.6.3checkout after all commits were assembled. The items below contradict what actually ships at the tag and must be resolved before merging.skill/references/cli/seid-cli.md(Node Start (seid start) →--freeze-height, bullet: "Also settable via thefreeze-heightfield in the[base]section ofapp.toml") — The freeze height is also settable via thefreeze-heightfield in the[base]section ofapp.toml.freeze-height = {{ .BaseConfig.FreezeHeight }}inside the ManualConfigTemplate under the "Base Configuration" comment banner (toml.go:17-19), which is at the TOP LEVEL of app.toml with no[base]TOML section header. The first section header in the template is[state-sync](toml.go:77); grep for[base]in toml.go returns no matches. There is no[base]section in app.toml, so the key does not live under a[base]section.Reviewer notes
release/v6.6: Add freeze mode for historical EVM RPC sei-chain#3978 — The primary home for this change is node-operations.md, which already documents app.toml BaseConfig fields (halt-height is a natural sibling) and node startup/systemd usage. The seid-cli.md addition is a secondary/optional judgment call — that file focuses on wallet/query/tx subcommands and does not currently document 'seid start' flags at all, so a reviewer may prefer to keep the flag documentation solely in node-operations.md. No existing skill mentions halt-height, so this is net-new content in both cases.release/v6.6: Add frozen RPC router and Docker integration cluster (#3989) sei-chain#4024 — The--freeze-heightflag is already well-documented in both cli/seid-cli.md and ecosystem/node-operations.md, and the existing exclusive-boundary description ('settles at freeze-height - 1') matches the PR — so the freeze-height flag itself is largely covered and may only need a cross-reference to the new router. The genuinely new, undocumented artifact is thefrozen-rpc-routerbinary and its CLI flags, which no skill file mentions; a new reference file is the primary gap. Proposed path cli/frozen-rpc-router.md fits the existing cli/ category; alternatively it could live under ecosystem/ since it's an operational proxy tool — judgment call left to the reviewer.release/v6.6: Bound block reference parsing depth sei-chain#4034 — The change is a single new CLI flag on frozen-rpc-router, fully covered by the existing frozen-rpc-router.md skill. The flag bounds nested block-reference depth (e.g. EIP-1898 {"blockNumber": ...} objects); the router now returns an empty/unknown reference (routing to live) when depth exceeds the limit. A brief note on this routing behavior for over-deep references could also be added to the Routing behaviour section, but the primary gap is the missing flag entry. The seid-cli.md frozen-rpc-router mentions are only cross-references and need no change.release/v6.6: Bound frozen RPC router batch allocations sei-chain#4048 — The frozen-rpc-router skill file is the only place documenting this command. The Flags table needs the two new rows, and the 'Other error codes' section should note that batches exceeding --batch-request-limit are rejected with code -32600 and message 'batch too large'. No other skill files reference these flags.Flagged by a review of every touched page's final text. Each source PR was analysed in isolation, so these were invisible to the per-PR checks. Verify before merging — the checker cannot tell which side of a contradiction is correct.
Analyzing the pages for the specified issues.
--freeze-heightapp.toml section (seid-cli.md): The new text says freeze-height is settable via the[base]section ofapp.toml, while node-operations.md (and the router page) treat it consistently—but within seid-cli.md itself it's stated as[base], whereas node-operations.md saysBaseConfigsection "alongside halt-height / halt-time". These are two different section names ([base]vsBaseConfig) for the same field across the update, but not on the same page — noting only same-page issues: no direct same-page contradiction here.sei_traceBlockByNumberExcludeTraceFailremoval vssei2_*ExcludeTraceFailremaining (node-operations.md): The "Removed (as of Sei v6.6.0)" bullet says the twosei_*block-trace endpoints are removed and can no longer be enabled, but then states thesei2_*ExcludeTraceFailblock variants "all remain." Meanwhile thesei2_*namespace section lists "the*ExcludeTraceFailvariants" as gated/enable-able methods. This is consistent (sei_ removed, sei2_ remain), so not a contradiction.NONE
Generated by sei-docs-bridge. Every change is a proposal — verify against the source PRs before merging.