Skip to content

xcp: Better fix - #5120

Merged
gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:xcp-fix
Aug 28, 2026
Merged

xcp: Better fix#5120
gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:xcp-fix

Conversation

@gpotter2

Copy link
Copy Markdown
Member

The XCP patch was merged slightly too quickly

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.63%. Comparing base (120a9da) to head (194cf31).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5120       +/-   ##
===========================================
+ Coverage   47.48%   80.63%   +33.14%     
===========================================
  Files         372      390       +18     
  Lines       96537    96903      +366     
===========================================
+ Hits        45844    78139    +32295     
+ Misses      50693    18764    -31929     
Files with missing lines Coverage Δ
scapy/contrib/automotive/xcp/cto_commands_slave.py 94.87% <100.00%> (+13.67%) ⬆️
scapy/contrib/automotive/xcp/xcp.py 93.22% <100.00%> (+7.99%) ⬆️

... and 340 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AI-Assisted: no
@gpotter2
gpotter2 merged commit 3f824e1 into secdev:master Aug 28, 2026
1 check was pending
@gpotter2
gpotter2 deleted the xcp-fix branch August 28, 2026 15:13
@polybassa

Copy link
Copy Markdown
Contributor

Doesn't this bring the code back to the original state?

@gpotter2

Copy link
Copy Markdown
Member Author

Yes, mostly. With a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants