LLDP: add IEEE 802.1Q and 802.1AX org-specific TLVs - #4970
Open
ali-keys wants to merge 3 commits into
Open
Conversation
|
Thanks for the PR. Could you please check if it is possible to add interoperability tests with existing tools or libraries, such as lldpd, to the unit tests. |
Contributor
Author
Hi Nils, by interoperability tests you mean: Making a real environment -> capturing everything -> writing tests based on the pcaps to make sure it gets parsed correctly? Like the last test ( |
|
No, those tests are also important, but if possible I have something like this in mind. Start lldpd with a certain configuration in a subprocess, In this way we can automatically verify the interaction with a real world application/libray. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4970 +/- ##
==========================================
+ Coverage 80.63% 80.67% +0.03%
==========================================
Files 390 390
Lines 96936 97089 +153
==========================================
+ Hits 78168 78324 +156
+ Misses 18768 18765 -3
🚀 New features to boost your workflow:
|
Member
|
LGTM, but the doc tests fail with |
ali-keys
force-pushed
the
lldp-ieee8021-tlvs
branch
from
June 11, 2026 08:13
0c153b2 to
8e2d6e7
Compare
Contributor
Author
Contributor
|
Regarding the interoperability tests, it doesn't matter if not all IDs are supported. At least we get an overall good coverage on AI generated code. |
ali-keys
force-pushed
the
lldp-ieee8021-tlvs
branch
from
July 31, 2026 09:50
8e2d6e7 to
bc7e272
Compare
Contributor
Author
|
@polybassa I added interoperability tests for LLDP (via While writing the tests I also found a bug in
I also made the regression tests to not fail when IPython is missing. (the change in PoC for the hang - tested with Python 3.12.3 (affected) and 3.14.6 (not affected): """
PoC: UTScapy (scapy.autorun) hangs forever when a test raises, on affected
"""
import sys
def check_python():
v = sys.version_info
affected = (v[:2] == (3, 12) and v[2] < 10) or (v[:2] == (3, 13) and v[2] < 3)
print(f"Python {sys.version.split()[0]} -- affected by gh-130250: {affected}")
return affected
def demo_cpython_bug():
"""Reproduce CPython gh-130250 standalone (no scapy)."""
import io
import traceback
try:
raise RuntimeError("boom")
except RuntimeError:
sys.last_exc = sys.exc_info()[1]
sys.last_type = type(sys.last_exc)
sys.last_value = sys.last_exc
sys.last_traceback = sys.last_exc.__traceback__
buf = io.StringIO()
try:
traceback.print_last(file=buf)
print("no error -- Python is fixed")
except AttributeError as e:
print(f"reproduced gh-130250: {e!r}")
def demo_scapy_hang():
"""Trigger the full UTScapy hang path."""
from scapy.autorun import autorun_get_interactive_session
cmds = "assert False, 'boom'\n"
print("calling autorun_get_interactive_session -- hangs on affected Python")
out, res = autorun_get_interactive_session(cmds, timeout=5)
print("returned:", repr(res))
if __name__ == "__main__":
check_python()
demo_cpython_bug()
demo_scapy_hang() |
ali-keys
force-pushed
the
lldp-ieee8021-tlvs
branch
from
July 31, 2026 10:06
bc7e272 to
5e824af
Compare
Contributor
Author
|
@polybassa, @gpotter2 anything to update here? |
Member
|
Hi @ali-keys, could you fix the conflicts by rebasing ? Tests also don't pass. Thanks ! |
…rg-specific dispatch AI-Assisted: yes (Claude Sonnet 4.6)
ali-keys
force-pushed
the
lldp-ieee8021-tlvs
branch
2 times, most recently
from
September 2, 2026 08:20
43b065b to
563d7e6
Compare
+ Emulate interact test to work without IPython installed AI-Assisted: yes (Claude Opus 4.7)
ali-keys
force-pushed
the
lldp-ieee8021-tlvs
branch
2 times, most recently
from
September 2, 2026 09:31
9772494 to
f30a2db
Compare
AI-Assisted: yes (Claude Opus 4.7)
ali-keys
force-pushed
the
lldp-ieee8021-tlvs
branch
from
September 2, 2026 09:41
f30a2db to
8db6c2e
Compare
Contributor
Author
|
@gpotter2 done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This PR adds 15 new org-specific TLVs for IEEE 802.1Q:
First, I wanted to implement only the ones that I needed (VLAN stuff), but then decided to implement all of them.
The code has been written mostly by AI. I've reviewed and corrected every line of it.