Skip to content

feat: add login secret visibility toggle - #222

Merged
cxymds merged 1 commit into
mainfrom
cxymds/login-secret-visibility
Sep 7, 2026
Merged

feat: add login secret visibility toggle#222
cxymds merged 1 commit into
mainfrom
cxymds/login-secret-visibility

Conversation

@cxymds

@cxymds cxymds commented Sep 7, 2026

Copy link
Copy Markdown
Member

Pull Request

Description

  • Add an eye control to reveal or mask the key-login secret.
  • Apply the same interaction to the STS secret field and reset visibility when switching login methods.
  • Provide localized, accessible show/hide labels for every bundled locale.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile
pnpm type-check
pnpm lint
pnpm format:check
pnpm test:run

All 483 tests pass. The reveal control was exercised in both key-login and STS modes at desktop and mobile viewports.

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

N/A

Screenshots (if applicable)

Before

Login form before the secret visibility control

After

Login form with the secret revealed using the visibility control

Additional Notes

The secret remains masked by default, and switching login methods restores the masked state.

Let users reveal or mask key-login and STS secret values while preserving accessible labels and mobile touch targets.
@cxymds
cxymds force-pushed the cxymds/login-secret-visibility branch from 881dfd9 to 0413569 Compare September 7, 2026 01:58
@cxymds
cxymds merged commit fd02c55 into main Sep 7, 2026
10 checks passed
@cxymds
cxymds deleted the cxymds/login-secret-visibility branch September 7, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant