fix(config): protect credentials before writing configuration - #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #357.
ConfigManager::savepreviously wrote alias credentials before tightening file permissions. An interrupted or failed write could leave the configuration readable by other local users.Create new Unix configuration files with mode
0600and tighten existing files through the opened file handle before truncating or writing. Add regression coverage that forces writes to fail under a permissive umask, checks both new and existing files, and verifies that shorter configuration updates remove stale trailing content.Protected-file review — BREAKING marker required by repository policy: this permission fix touches
crates/core/src/config.rs. The configuration schema remains at version 1, existing files remain compatible, and no data migration is needed.Validation on macOS:
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace— 2,649 passed, 2 ignored