Skip to content

Remove temporary eval history configuration - #1240

Merged
tompng merged 1 commit into
ruby:masterfrom
OskarEichler:codex/eval-history-temp-key
Aug 30, 2026
Merged

Remove temporary eval history configuration#1240
tompng merged 1 commit into
ruby:masterfrom
OskarEichler:codex/eval-history-temp-key

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Summary

Delete the same temporary configuration key that eval-history initialization inserts.

Reproduction

Initialization writes IRB.conf[:__TMP__EHV__] but deletes the mistyped :__TMP_EHV__, leaving the history object in global configuration after the workspace binding is established.

Verification

  • current and cumulative candidate suites: 402 tests / 2,488 assertions, zero failures/errors and three omissions
  • all 111 Ruby files pass syntax
  • RuboCop checks 113 files with no offenses
  • RDoc and Rails 8.1.3.1 loading pass

Compatibility

Removes only an internal temporary key after its intended one-shot use. Prepared with AI-assisted source review; no repository tests were changed.

@tompng tompng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@tompng
tompng merged commit fc88f2e into ruby:master Aug 30, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants