Skip to content

Honor explicit AUTO_INDENT false in prompt modes - #1239

Merged
tompng merged 1 commit into
ruby:masterfrom
OskarEichler:codex/auto-indent-false
Aug 30, 2026
Merged

Honor explicit AUTO_INDENT false in prompt modes#1239
tompng merged 1 commit into
ruby:masterfrom
OskarEichler:codex/auto-indent-false

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Summary

Read the prompt mode's AUTO_INDENT value after checking key presence, so an explicit false disables indentation instead of becoming true.

Reproduction

A prompt configuration containing AUTO_INDENT: false currently stores the result of Hash#include?, which is true. The candidate stores the configured value.

Verification

  • current and cumulative candidate suites: 402 tests / 2,488 assertions, zero failures/errors and three omissions
  • all 111 Ruby files pass syntax
  • RuboCop checks 113 files with no offenses
  • RDoc and Rails 8.1.3.1 loading pass

Compatibility

Only explicit false prompt configuration changes, to match its documented intent. Prepared with AI-assisted source review; no repository tests were changed.

@tompng tompng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tompng
tompng merged commit a54523c into ruby:master Aug 30, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants