Skip to content

Link carries type="button" on an <a> #553

Description

@cirdes
  • Where: link.rb default_attrs {type: "button", ...}, copied from Button. Snapshots link/*.
  • Effect: type on an anchor names the linked resource's MIME type; button is meaningless there. Invalid, harmless.
  • Fix: drop type: from Link's default_attrs; re-record link/*.

Surfaced by the strict lane of the golden HTML suite (PR #548), which pins what 1.6 renders today — this defect included. Per maintainer decision (2026-09-19) main stays as is: this is addressed on the 2.0 line, and the golden snapshots that pin it are re-recorded there with the diff reviewed.

Source: design/v2/follow-up-issues.md.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions