fix(rilltime): accept legacy DAX comparison offsets in ParseLegacy - #9869
Open
pjain1 wants to merge 2 commits into
Open
fix(rilltime): accept legacy DAX comparison offsets in ParseLegacy#9869pjain1 wants to merge 2 commits into
pjain1 wants to merge 2 commits into
Conversation
Alerts and reports created before the legacy time range refactor store comparison time ranges with an iso_offset of rill-PD/PW/PM/PQ/PY, which ParseLegacy rejected with "offset cannot have DAX notation". Map those tokens to the equivalent ISO offsets and treat rill-PP as a previous period offset, matching the pre-refactor behaviour. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The unrelated CLI test always fails because EditCmd does not define the flag it exercises.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds backward compatibility for legacy DAX comparison offsets in ParseLegacy.
Changes:
- Maps legacy DAX offsets to ISO durations.
- Supports
rill-PPas the previous period. - Adds compatibility tests and an unrelated CLI test.
File summaries
| File | Description |
|---|---|
runtime/pkg/rilltime/rilltime.go |
Parses legacy DAX comparison offsets. |
runtime/pkg/rilltime/rilltime_test.go |
Tests valid and invalid legacy offsets. |
cli/cmd/sudo/project/edit_test.go |
Adds an unsupported cloud-editing command test. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alerts and reports created before the legacy time range refactor store comparison time ranges with an iso_offset of rill-PD/PW/PM/PQ/PY, which ParseLegacy rejected with "offset cannot have DAX notation". Map those tokens to the equivalent ISO offsets and treat rill-PP as a previous period offset, matching the pre-refactor behaviour.
Checklist: