Fix flaky and racy tests in the daily Go test run - #9868
Open
begelundmuller wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues seen in the daily test run here: https://github.com/rilldata/rill/actions/runs/34086202592
KeepAlivefrom the MCP server options: sessions are served over stateless streamable HTTP and live for a single request, so it never fires usefully, but it races with the session close at the end of the request (TestMCPfailed under-racein the last three daily runs; fixed upstream in go-sdk v1.6.0).container_namefrom the ClickHouse cluster compose file so parallel packages each get their own containers instead of colliding onclickhouse-keeper-01.