fix(response): serialize response data as JSON - #240
Open
nickita-khylkouski wants to merge 1 commit into
Open
nickita-khylkouski wants to merge 1 commit into
nickita-khylkouski wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delegate
Resend::Response#to_jsonto the wrapped response data. This makes direct and nested JSON serialization emit the API data instead of serializing the wrapper's instance variables.Testing
bundle exec rake: 405 examples, 0 failuresSummary by cubic
Fixes
Resend::ResponseJSON serialization soto_jsonreturns the API data instead of the wrapper's internal state.JSON.generatecalls now all serialize the response data as expected.pretty_generateare preserved.Written for commit a5e1e33. Summary will update on new commits.