fix(ci): keep uv.lock in step with the release version bump - #699
Open
vishal-bala wants to merge 1 commit into
Open
fix(ci): keep uv.lock in step with the release version bump#699vishal-bala wants to merge 1 commit into
vishal-bala wants to merge 1 commit into
Conversation
The release job bumped the version in pyproject.toml but committed only that file, leaving uv.lock's own redisvl version stale after every release. Bump both, verify the edit before anything is pushed, and add a `uv lock --check` job to lint so drift fails on the PR instead of in the next contributor's working tree.
vishal-bala
marked this pull request as ready for review
August 24, 2026 13:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job bumps
versioninpyproject.tomlbut commits only that file, souv.lock— which carries the project's own version — goes stale after every release, and the next contributor to runmake installpicks up an unrelated bump in their PR. Nothing caught it:uv sync --frozentakes the lock as-is, and at tagv0.26.0it installedredisvl==0.26.0from a lock that still said0.25.1.The release job now bumps both files and verifies the edit before anything is committed or pushed: one changed line per file, and the new version on the
redisvlentry specifically. It edits that one field rather than runninguv lock, which re-serializes the whole file (258 lines of marker churn here) right aftercanary-buildvalidated the old one. A newlockjob inlint.ymlrunsuv lock --checkso drift fails on the PR — note that a PR editing dependency specifiers without re-locking will now fail it; fix isuv lock.Note
Medium Risk
Touches the auto-release job that commits to main and tags/publishes, so a bad sed or check could stall or mis-bump a release. Lock-check is otherwise low-risk CI.
Overview
Stops the release bot from leaving
uv.lockstale after it bumpspyproject.toml. The project's own version in the lock is edited in place (not a fulluv lockre-serialize), then checked: one version line per file, theredisvlentry specifically, anduv lock --check. Both files are committed together.Lint CI gains a
lockjob that runsuv lock --checkso dependency-spec changes without a re-lock fail on the PR. CONTRIBUTING notes that contributors should runuv lockwhen changing deps. This PR also aligns the lock'sredisvlversion to0.26.0.Reviewed by Cursor Bugbot for commit 53aa941. Bugbot is set up for automated code reviews on this repo. Configure here.