Skip to content

Add pagination to the other tables under details tabs to release branch 4.18 - #274

Merged
keithchong merged 1 commit into
redhat-developer:release-4.18from
aali309:paginationPart2-release-4.18
Aug 21, 2026
Merged

Add pagination to the other tables under details tabs to release branch 4.18#274
keithchong merged 1 commit into
redhat-developer:release-4.18from
aali309:paginationPart2-release-4.18

Conversation

@aali309

@aali309 aali309 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

same as #273 but for release branch 4.18

Signed-off-by: Atif Ali <atali@redhat.com>
@openshift-ci
openshift-ci Bot requested review from keithchong and wtam2018 August 20, 2026 21:22
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0605a440-07f2-4623-b02a-a67c1df01010

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-4.18@ff3f476). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../gitops/components/application/History/History.tsx 0.00% 7 Missing ⚠️
...s/components/application/ApplicationSourcesTab.tsx 0.00% 5 Missing ⚠️
...omponents/application/ApplicationResourcesView.tsx 0.00% 4 Missing ⚠️
...omponents/application/ApplicationSyncStatusTab.tsx 0.00% 4 Missing ⚠️
...ents/imageupdater/ImageUpdaterRecentUpdatesTab.tsx 0.00% 4 Missing ⚠️
src/gitops/components/project/ProjectRolesTab.tsx 0.00% 4 Missing ⚠️
...itops/components/project/ProjectSyncWindowsTab.tsx 0.00% 4 Missing ⚠️
.../components/rollout/components/PodList/PodList.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-4.18     #274   +/-   ##
===============================================
  Coverage                ?   12.35%           
===============================================
  Files                   ?      171           
  Lines                   ?     6834           
  Branches                ?     2318           
===============================================
  Hits                    ?      844           
  Misses                  ?     5989           
  Partials                ?        1           
Flag Coverage Δ
unit-tests 12.35% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keithchong keithchong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithchong
keithchong merged commit 9b99a0d into redhat-developer:release-4.18 Aug 21, 2026
5 checks passed
@aali309
aali309 deleted the paginationPart2-release-4.18 branch August 21, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants