Skip to content

Add Pagination in release branch 4.18 - #272

Merged
keithchong merged 3 commits into
redhat-developer:release-4.18from
aali309:pagination-release-4.18
Aug 20, 2026
Merged

Add Pagination in release branch 4.18#272
keithchong merged 3 commits into
redhat-developer:release-4.18from
aali309:pagination-release-4.18

Conversation

@aali309

@aali309 aali309 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

applied #266 on 4.18 release branch

Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
@openshift-ci
openshift-ci Bot requested review from keithchong and wtam2018 August 20, 2026 16:57
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7bb787ea-2ea8-445f-b82a-b40cd483b7cc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.49541% with 121 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-4.18@2ab6506). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...components/shared/DataView/GitOpsDataViewTable.tsx 0.00% 56 Missing ⚠️
src/gitops/components/shared/ApplicationList.tsx 0.00% 17 Missing ⚠️
src/gitops/components/rollout/RolloutList.tsx 0.00% 11 Missing ⚠️
...itops/components/imageupdater/ImageUpdaterList.tsx 0.00% 10 Missing ⚠️
src/gitops/components/project/ProjectList.tsx 0.00% 10 Missing ⚠️
...rc/gitops/components/shared/ApplicationSetList.tsx 0.00% 10 Missing ⚠️
...gitops/components/shared/applicationListFilters.ts 88.88% 4 Missing ⚠️
...rc/gitops/components/shared/listPageTextFilters.ts 96.07% 2 Missing ⚠️
...mponents/shared/ApplicationSetApplicationsView.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-4.18     #272   +/-   ##
===============================================
  Coverage                ?   12.36%           
===============================================
  Files                   ?      171           
  Lines                   ?     6824           
  Branches                ?     2257           
===============================================
  Hits                    ?      844           
  Misses                  ?     5979           
  Partials                ?        1           
Flag Coverage Δ
unit-tests 12.36% <44.49%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keithchong keithchong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's one minor alignment issue that we can address separately. (Likely for main too)

@keithchong
keithchong merged commit ff3f476 into redhat-developer:release-4.18 Aug 20, 2026
5 checks passed
@aali309
aali309 deleted the pagination-release-4.18 branch August 20, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants