[TypeDeclarationDocblocks] Widen empty nested array default to mixed[] in DocblockVarArrayFromPropertyDefaultsRector - #8474
Merged
Conversation
…] in DocblockVarArrayFromPropertyDefaultsRector Remove the hasEmptyNestedArray guard so a map whose values are empty arrays (e.g. ['select' => [], 'from' => []]) gets a @var array<string, mixed[]> docblock instead of being skipped. Only a direct single [] default stays skipped. Claude-Session: https://claude.ai/code/session_01F6Coa2BZXNc18QhSVkhrYe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
hasEmptyNestedArrayguard fromDocblockVarArrayFromPropertyDefaultsRector.A private array property whose default is a map of empty arrays, e.g.:
was skipped by the guard, even though widening to
@var array<string, mixed[]>is the intended behavior. This restores that. A direct single[]default stays skipped as before (handled by the decorator, not the guard).The stale conflicting
skip_empty_nested_array.php.incfixture (same input shape, opposite expectation) is removed.