[Unambiguous] Deprecate FluentSettersToStandaloneCallMethodRector and RemoveReturnThisFromSetterClassMethodRector - #8473
Merged
Conversation
… RemoveReturnThisFromSetterClassMethodRector Both need a more complex approach depending on the use case - breaking a fluent chain or dropping return $this can silently change a public fluent API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both rules are orphans (in no set) and depend too much on the use case to run generically:
return $thisfrom setters. The setter may be part of a fluent public API that callers rely on, so the change can silently break code.Both deprecated via the standard pattern: body throws,
DeprecatedInterface+@deprecated, tests removed. The now-orphanedFluentMethodCallsCollectorhelper and the single-callerClassMethodAndPropertyAnalyzer::hasPropertyAssignWithReturnThis()method are removed too.