test: pin leftover Esplora HTTP on the cross-surface pad - #559
Merged
Merged
Conversation
edge-case-coverage-audit slices 9–20 already landed. Remaining B12/slice-10 honesty: /blocks start past tip clamps, /txs one-past last page is [] not 404, plus txids / merkle-proof / unspent outspend on the mined tip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit vs tree
local/edge-case-coverage-audit.mdremaining slices 9–20 already landed (A9 wait/GBT, B15 getblock, A10slots.tmp, A12/B16 CLI, A11 BQ/feeler/evict, B7 16 vs 17, B8 genesis+1 IBD, B9 held park, B10 subsidy overlay, B17 tip shrink, A8 blocksonly Electrum/Esplora, B3/B14 maxfee/scan). Catalog:TESTING.md.This PR (slice 10 leftover)
The audit still wanted extra Esplora HTTP on the live
run_p2ppad, and B12 “out-of-range start 404”. Shipped Esplora (like Blockstream) returns empty[], not 404, past the last/txspage;/blocks/:startclamps past tip.Pins on
esplora_broadcast_visible_in_rpc_and_electrum:GET /blocks/{tip+1}same 10 as/blocks/{tip}GET /block/:hash/txs/{next}empty 200GET /block/:hash/txids, coinbase/tx/:txid/merkle-proof, unspent/outspend/0No production change.
cargo test -p rbitcoin-test --test cross_surface esplora_broadcast_visible_in_rpc_and_electrumgreen.