fix: migrate docs, stale height_of_hash, tight analog pins - #556
Merged
Merged
Conversation
rearden-grok
Bot
force-pushed
the
fix/post-06-doc-pins
branch
from
September 15, 2026 18:38
754de33 to
8197dd3
Compare
rearden-grok
Bot
force-pushed
the
fix/post-06-doc-pins
branch
from
September 15, 2026 18:47
f4199c1 to
91ccb5f
Compare
invariants.md and OPERATOR.md now match open(): meta first, then occupied-22 ovf / occupied-23 header.body. height_of_hash retries the live tip when a snapshot walks past confirmed (RPC/Esplora get None, not Corrupt). core_analogs missing-prevout and empty estimatesmartfee assert the shipped error class.
ensure_height_by_hash_index already retries the live tip. The extra height_of_hash wrap was uncovered. Drive the no-tip unpublished ensure so stale_or_missing clears the map.
Need a few more production hits so LH/LF does not fall vs master 91.25% (unrounded). Drive the empty-locator stop-hash arms and wire_header_from_record_prev's cached prev from the stale-h2h journey.
Unrounded never-falls still needed ~5 more hits vs master 103271/113171.
rearden-grok
Bot
force-pushed
the
fix/post-06-doc-pins
branch
from
September 15, 2026 19:30
32abe67 to
af15a77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Last four leftover items from the post-0.6 audit:
docs/invariants.mdstill said format migrate is none-on-open.OPERATOR.mdoccupied-22/23 listed ovf/header.body beforemeta.height_of_hashsnapshot after disconnect couldCorruptRPC/Esplora.core_analogsprevout OR included"invariant"; emptyestimatesmartfeeaccepted a positive rate ifrbitcoin_modelwas set.Contract
metafirst, then ovf /header.body; miss at/below live tip stays Corrupt; request past live tip retries live tip (height_of_hash_stale_snapshot_after_confirmed_shrink_is_none).ConsensusError::MissingPrevout/bad-txns-inputs-missingorspent.estimatesmartfeeisfeerate == -1.0plus the insufficient-dataerrorsarray, no model key.Do not merge unless asked.