Name CustomStyleSpan's font style and weight for what they hold - #57979
Closed
Abbondanzo wants to merge 1 commit into
Closed
Name CustomStyleSpan's font style and weight for what they hold#57979Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
Summary: `CustomStyleSpan` held its two typeface axes as `privateStyle` and `privateWeight`, named that way only to dodge a collision with the normalising `style` and `weight` getters. That detail then leaked into every call site that wanted to use named arguments. The collision is now resolved from the other side. The two normalising getters become `effectiveStyle` and `effectiveWeight`, matching `effectiveFontSize`, `effectiveLineHeight` and `effectiveLetterSpacing` on `TextAttributes` as well as the `effectiveFontStyle` and `effectiveFontWeight` locals that `ReactEditText` already compares them against. They are computed once when the span is constructed rather than on every read. Changelog: [Internal] Differential Revision: D115621390
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115621390. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
CustomStyleSpanheld its two typeface axes asprivateStyleandprivateWeight, named that way only to dodge a collision with the normalisingstyleandweightgetters. That detail then leaked into every call site that wanted to use named arguments.The collision is now resolved from the other side. The two normalising getters become
effectiveStyleandeffectiveWeight, matchingeffectiveFontSize,effectiveLineHeightandeffectiveLetterSpacingonTextAttributesas well as theeffectiveFontStyleandeffectiveFontWeightlocals thatReactEditTextalready compares them against. They are computed once when the span is constructed rather than on every read.Changelog: [Internal]
Differential Revision: D115621390