Delete the "load-bearing" filler - #146
Conversation
The phrase rates a finding instead of stating one, and the reader can do the rating. Each of the 2 occurrences is either deleted -- where the sentence around it already named the consequence -- or replaced by the consequence it was standing in for. No substitute rating word was introduced. No behaviour change: comments and prose only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe pull request clarifies two LibFs test comments. The comments document first-generation file absence, required removal checks, and tagged-directory creation before writing. ChangesLibFs test documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change removes filler wording from two test-file comments without changing runtime behavior, so no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The previous run failed three fuzz cases with `vm.etch: failed to create bytecode: Unsupported Eip7702 version.` -- the fuzzer drew bytes starting 0xef01, which foundry now refuses to etch. Seed-dependent and unrelated to this diff (two doc comments in the LibFs tests); the same commit's base passed the identical workflow on branch lbsweep-baseline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Removes the banned
load-bearingfiller from this repo's committed source.The phrase rates a finding instead of stating one, and the reader can do the rating.
Where the surrounding sentence already named the consequence, the phrase is simply
deleted; otherwise it is replaced by the consequence it was standing in for. No
substitute rating word ("crucial", "key", "critical", "the crux", "significant",
"notably") was introduced anywhere in the diff.
Closes nothing — no issue exists for this. Part of an org-wide sweep; one PR per
affected repo. GitHub code search finds only some of the forms, so the sweep was run
against fresh clones of all 151 org repos, matching
load[-_ ]?bearingcase-insensitivelyplus a check for the phrase wrapped across two comment lines.
Occurrences removed
test/src/lib/LibFs.buildFileForContract.t.soltest/src/lib/LibFs.buildFileForTaggedContract.t.solQA
behaviour for a test to discriminate.
mutation-probemutatessource lines and asks whether the suite kills them; this diff changes no source line,
so every mutant it could generate is a mutant of code this PR did not touch.
phrase was gesturing at, read off the surrounding implementation rather than invented.
this repo's occurrences are all removed and a re-grep over the branch finds none.
Summary by CodeRabbit