Skip to content

[docker] Add return types for node model operations #16236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 1 commit into from
Aug 18, 2026
+5 −5
Merged

[docker] Add return types for node model operations #16236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions stubs/docker/docker/models/nodes.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
from builtins import list as _list
from typing import Any
from typing import Any, Literal

from .resource import Collection, Model

class Node(Model):
id_attribute: str
@property
def version(self): ...
def update(self, node_spec): ...
def remove(self, force: bool = False): ...
def version(self) -> int: ...
def update(self, node_spec) -> Literal[True]: ...
def remove(self, force: bool = False) -> Literal[True]: ...

class NodeCollection(Collection[Node]):
model: type[Node]
def get(self, node_id): ...
def get(self, node_id) -> Node: ...
# Please keep in sync with docker.api.swarm.SwarmApiMixin.nodes
def list(self, filters: dict[str, Any] | None = None) -> _list[Node]: ... # Any: filter values + Node response