Annotate braintree's MultipleValueNodeBuilder.in_list method - #16235
Open
cuu508 wants to merge 1 commit into
Open
Annotate braintree's MultipleValueNodeBuilder.in_list method#16235cuu508 wants to merge 1 commit into
cuu508 wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
donbarbos
suggested changes
Aug 18, 2026
donbarbos
left a comment
donbarbos
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Just one nit
| whitelist: Incomplete | ||
| def __init__(self, name, whitelist=[]) -> None: ... | ||
| def in_list(self, *values): ... | ||
| def in_list(self, *values: str) -> Search.Node: ... |
Contributor
There was a problem hiding this comment.
Since a list can be used as such a sequence of values for the first argument, I think it might be worth adding an overload for this case.
(Please, import Unused from _typeshed)
Suggested change
| def in_list(self, *values: str) -> Search.Node: ... | |
| @overload | |
| def in_list(self, value: list[str], *values: Unused) -> Search.Node: ... | |
| @overload | |
| def in_list(self, *values: str) -> Search.Node: ... | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds type annotations for
braintree.search.Search.MultipleValueNodeBuilder.in_list.Looking at the source, the return value can only be Search.Node.
It's less clear what the type of
*valueselements can be, but grepping around the source it looked like it's onlystr.