fix: preserve PEP 661 sentinels in dict.get inference - #21867
Open
mgalore wants to merge 1 commit into
Open
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
cdce8p
suggested changes
Aug 18, 2026
cdce8p
left a comment
Collaborator
There was a problem hiding this comment.
While this appears to solve the issue, I'm not sure we should change constaints.py. We don't do that for enums either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21866.
dict.get()infers its default through a type variable. For a PEP 661 sentinel, constraint inference used theSentinelfallback instance instead of its sentinel literal, producingstr | sentinelrather thanstr | Unknown.Preserve a sentinel
last_known_valuewhen creating a direct type-variable constraint, and add the reported regression case.Verification:
PATH="$PWD/.venv/bin:$PATH" .venv/bin/python -m pytest -n0 -q mypy/test/testcheck.py::TypeCheckSuite::check-sentinels.testPATH="$PWD/.venv/bin:$PATH" .venv/bin/python runtests.py(12,860 + 601 + 55 tests passed; expected skips/xfails)PATH="$PWD/.venv/bin:$PATH" .venv/bin/python runtests.py lint.venv/bin/pre-commit run black --files mypy/constraints.py.venv/bin/pre-commit run ruff-check --files mypy/constraints.py