gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 - #155293
Merged
Conversation
Due to a bug, some Unicode codepoint attributes were considered for characters not yet defined in Unicode 3.2.0 or attributes which changed in later Unicode versions. RFC 3454 (StringPrep) requires using Unicode 3.2.0 strictly. Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com>
Contributor
Author
|
@StanFromIreland @malemburg Now that GHA service has recovered, requesting a review on this PR. |
encukou
reviewed
Aug 11, 2026
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Member
|
I filed a suggestion as a PR: sethmlarson#2. Otherwise, LGTM -- I didn't find another issue. @malemburg would be the best person to review this, of course. Marc-André, should we wait for you? |
malemburg
reviewed
Aug 13, 2026
malemburg
left a comment
malemburg
left a comment
Member
There was a problem hiding this comment.
I don't have time for a review, but from casual inspection, this looks good to me. Thanks.
Member
|
Thanks for the fix!
OK; let me know if you want to delegate. |
encukou
added
the
needs backport to 3.15
|
Thanks @sethmlarson for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-156017 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Aug 18, 2026
…RFC 3454 (pythonGH-155293) Due to a bug, some Unicode codepoint attributes were considered for characters not yet defined in Unicode 3.2.0 or attributes which changed in later Unicode versions. RFC 3454 (StringPrep) requires using Unicode 3.2.0 strictly. Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> (cherry picked from commit 7e109d0)
|
GH-156020 is a backport of this pull request to the 3.14 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Aug 18, 2026
… RFC 3454 (GH-155293) (#156017) gh-155292: Don't consider Unicode codepoint attributes outside RFC 3454 (GH-155293) Due to a bug, some Unicode codepoint attributes were considered for characters not yet defined in Unicode 3.2.0 or attributes which changed in later Unicode versions. RFC 3454 (StringPrep) requires using Unicode 3.2.0 strictly. (cherry picked from commit 7e109d0) Co-authored-by: Seth Larson <seth@python.org> Co-authored-by: Stan Ulbrych <89152624+stanfromireland@users.noreply.github.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a bug, some Unicode codepoint attributes were considered
for characters not yet defined in Unicode 3.2.0 or attributes
which changed in later Unicode versions. RFC 3454 (StringPrep)
requires using Unicode 3.2.0 strictly.
This PR fixes
makeunicodedata.pyand re-runsmkstringprep.pywith the new Unicode database. In the futuremkstringprep.pyshould be run as a part ofmakeunicodedata.py.I'll take on backporting this PR manually, as we'll need to apply the patch and then re-execute
makeunicodedata.pyfor each Python version as each contains a different Unicode version.