Support for bulk operations - #149
Open
frohrlich wants to merge 1 commit into
Open
Conversation
frohrlich
force-pushed
the
bulk-operations
branch
from
August 24, 2026 12:48
31ed8e3 to
965e405
Compare
frohrlich
marked this pull request as draft
August 24, 2026 12:52
frohrlich
force-pushed
the
bulk-operations
branch
from
August 24, 2026 13:20
965e405 to
899a249
Compare
frohrlich
force-pushed
the
bulk-operations
branch
from
August 24, 2026 13:27
df89ee0 to
f049d6e
Compare
frohrlich
marked this pull request as ready for review
August 24, 2026 13:29
This was
linked to
issues
Aug 24, 2026
azmeuk
reviewed
Aug 27, 2026
| raise InvalidValueException( | ||
| detail="data is required for POST, PUT, or PATCH request operations" | ||
| ).as_pydantic_error() | ||
| elif scim_ctx and Context.is_response(scim_ctx): # pragma: no branch |
azmeuk
reviewed
Aug 27, 2026
| @model_validator(mode="after") | ||
| def validate_operation_requirements(self, info: ValidationInfo) -> Self: | ||
| """Validate operation requirements according to RFC 7644.""" | ||
| scim_ctx = info.context.get("scim") if info.context else None |
Member
There was a problem hiding this comment.
Please return early when scim_ctx is None to align the behavior to the rest of the library.
azmeuk
reviewed
Aug 27, 2026
| if self.location is None and not ( | ||
| self.method == BulkOperation.Method.post | ||
| and self.status is not None | ||
| and self.status >= 400 |
Member
There was a problem hiding this comment.
The RFC says:
response The HTTP response body for the specified request
operation. When indicating a response with an HTTP status
other than a 200-series response, the response body MUST be
included. For normal completion, the server MAY elect to omit
the response body.
So technically that would include the 1** and 3** error responses
Member
|
Please unlist the bulk samples in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See RFC7644#3.7. Bulk Operations
Resolves #13, #14, #15, #16, #18.