Fix build hook compatibility with Hatchling 1.32.1 - #132
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 95.90% 95.94% +0.03%
==========================================
Files 14 15 +1
Lines 1271 1281 +10
==========================================
+ Hits 1219 1229 +10
Misses 52 52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hatchling 1.32.1 breaks plugin imports by adding a second generic parameter to
BuildHookInterface. Remove runtime generic arguments from the build hook and add a registration/construction regression test. This preserves hook compatibility with older Hatchling versions.The same upstream release also imports
hatch.plugin.managerwithout declaring Hatch, breaking CLI builds withModuleNotFoundError. Exclude exactly 1.32.1 in build-system, runtime, and development requirements so installations select a working backend without requiring Hatch. Future releases remain allowed within existing version bounds.Verified without Hatch installed: 77 selected C++ tests pass with resolved Hatchling 1.32.0, and isolated wheel/sdist builds pass. Hook regression tests were also verified against 1.20.0 and 1.32.1. Versions remain unchanged.
Type of Change
Checklist