Monitors and actuators acces from tuning tools

[gubaidulinvadim]

@simoneliuzzo this answers #178 and makes a public access to monitors and actuators of tuning tools in pyAML. @JeanLucPons is there any reason to keep them "private"?

It is possible to do now, for example,

print(sr.design.tune.quadrupoles)

to access the quadrupole array used for tune correction. Before, it was "hidden" as a private attribute _quadrupoles.

For #414 , public access to monitors and actuators would need to be made a requirement for a generic tuning tool.

@simoneliuzzo I am trying to also answer #177, but I think this is already implemented. I am not sure if your issue also means something like swapping the tune monitor for an existing Tune tuning tool or simply a request on the interface in the constructor.

Currently, you can make a Tune tuning tool with a selected betatron_tune_name (tune monitor name). You'd still need to attach it to the simulator or control system after creation, but this is a general pyAML interface as of now for interactive object creation.

tune2 = Tune('ALTUNE', quad_array_name='QCORR', response_matrix='respmat.json', betatron_tune_name='BETATRON_TUNE2')
tune2.attach(sr.design)
tune2.attach(sr.live)
print(tune2.tune_monitor)

Resolves #178
Resolves #177

[JeanLucPons]

No there is no reason to keep it private.
It is ok for me.

[JeanLucPons]

@gubaidulinvadim
Concerning attachment of self created tool, i think it was already discussed and the idea would be to add a add() method to Accelerator that will automatically do attachment to each cs or simulator instance.

tune2 = Tune('ALTUNE', quad_array_name='QCORR', response_matrix='respmat.json', betatron_tune_name='BETATRON_TUNE2')
tune2.attach(sr.design)
tune2.attach(sr.live)
print(tune2.tune_monitor)

should be:

tune2 = Tune('ALTUNE', quad_array_name='QCORR', response_matrix='respmat.json', betatron_tune_name='BETATRON_TUNE2')
sr.add(tune2)
print(tune2.tune_monitor)

[gubaidulinvadim]

@gubaidulinvadim Concerning attachment of self created tool, i think it was already discussed and the idea would be to add a add() method to Accelerator that will automatically do attachment to each cs or simulator instance.

tune2 = Tune('ALTUNE', quad_array_name='QCORR', response_matrix='respmat.json', betatron_tune_name='BETATRON_TUNE2')
tune2.attach(sr.design)
tune2.attach(sr.live)
print(tune2.tune_monitor)

should be:

tune2 = Tune('ALTUNE', quad_array_name='QCORR', response_matrix='respmat.json', betatron_tune_name='BETATRON_TUNE2')
sr.add(tune2)
print(tune2.tune_monitor)

Thanks, that's clear. I've only written it to explain in the PR that this will be improved later.

[gubaidulinvadim]

@simoneliuzzo @JeanLucPons Sorry, there was a merge conflict with main (in the docstrings). This needs to be reapproved.